-
-
Notifications
You must be signed in to change notification settings - Fork 823
Refactor tests to load flake inputs with flake-compat #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6eb557c to
9cd60f4
Compare
This makes `nix fmt` just works and we no longer have to override flake inputs.
The broadcom-sta driver package is marked as insecure due to CVE-2019-9501 and CVE-2019-9502 (heap buffer overflow vulnerabilities allowing remote code execution). The driver is also unmaintained and incompatible with modern Linux kernel security mitigations. Removed broadcom_sta from extraModulePackages and the corresponding "wl" kernel module. This resolves test failures where Nixpkgs refuses to evaluate configurations containing this insecure package.
in ci, there is no cache, so it's just overhead and prints warnings.
|
@Mic92, you removed wifi from my MacBook Air 6.2. I prefer having an insecure wifi driver than having no internet at all. So I manually added the lines to my nix-configuration. Is your plan to completely disable internet on these computers, or do you have a better solution? |
No, but I had to remove it to fix evaluation of these modules. We can have an option that is not enabled by default to fix it though. |
|
With these lines: I get no evaluation error. We can add that and keep the wl/Broadcom module enabled. |
|
Do you want to add this? It would be better to override the broadcom package instead of nixpkgs.config.allowInsecurePredicate since some people and CI us using nixpkgs.pkgs instances: |
|
Yes, I updated my configuration. It works on my MacBook Air 6.2, thank you :-) |
|
Okay. Please make a pull request. |
|
Yes, I’ll do that. It will be my first NixOS pull request. |
|
✔️ All done 🙂 |
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input